Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded Values? #1057

Closed
razic opened this issue Mar 3, 2015 · 6 comments
Closed

Hardcoded Values? #1057

razic opened this issue Mar 3, 2015 · 6 comments

Comments

@razic
Copy link

razic commented Mar 3, 2015

Not sure what's going on here... but it appears that there may be some very weird hardcoded values in the code.

My docker-compose.yml:

web:
  build: .
  ports:
    "8080:8080"
  links:
    - "redisReads:redisReads"
    - "redisWrites:redisWrites"
    - "redisEphemeral:redisEphemeral"
redisReads:
  image: redis
redisWrites:
  image: redis
redisEphemeral:
  image: redis

and running:

compose stop && compose rm --force && compose build && compose up

results in:

Creating polka_redisEphemeral_1...
Creating polka_redisReads_1...
Creating polka_redisWrites_1...
Creating polka_web_1...
Traceback (most recent call last):
  File "<string>", line 3, in <module>
  File "/Users/ben/fig/build/docker-compose/out00-PYZ.pyz/compose.cli.main", line 31, in main
  File "/Users/ben/fig/build/docker-compose/out00-PYZ.pyz/compose.cli.docopt_command", line 21, in sys_dispatch
  File "/Users/ben/fig/build/docker-compose/out00-PYZ.pyz/compose.cli.command", line 27, in dispatch
  File "/Users/ben/fig/build/docker-compose/out00-PYZ.pyz/compose.cli.docopt_command", line 24, in dispatch
  File "/Users/ben/fig/build/docker-compose/out00-PYZ.pyz/compose.cli.command", line 59, in perform_command
  File "/Users/ben/fig/build/docker-compose/out00-PYZ.pyz/compose.cli.main", line 445, in up
  File "/Users/ben/fig/build/docker-compose/out00-PYZ.pyz/compose.project", line 183, in up
  File "/Users/ben/fig/build/docker-compose/out00-PYZ.pyz/compose.service", line 258, in recreate_containers
  File "/Users/ben/fig/build/docker-compose/out00-PYZ.pyz/compose.service", line 226, in create_container
  File "/Users/ben/fig/build/docker-compose/out00-PYZ.pyz/compose.service", line 437, in _get_container_create_options
TypeError: cannot concatenate 'str' and 'list' objects

My username is not ben and I have no users named ben.

/cc @benlangfeld

Compose version (darwin 64):

docker-compose 1.1.0-rc2
@benlangfeld
Copy link

This is more likely something to do with @bfirsh and the build process.

@razic
Copy link
Author

razic commented Mar 3, 2015

@benlangfeld How would I look into debugging or fixing it? I can create a pull.

@dnephin
Copy link

dnephin commented Mar 3, 2015

This error is because ports is being set to a string , but it needs to list. It should be

ports:
    - "8080:8080"

Related to #129

Edit: If you're curious, I found this by doing git checkout 1.1.0-rc2 and looking at that line, which is about ports.

@razic
Copy link
Author

razic commented Mar 3, 2015

Sure, it should be an array. But it also shouldn't have someone I don't even know personally identifiable information in the stack trace.

Sent from my iPhone

On Mar 3, 2015, at 2:47 PM, Daniel Nephin notifications@github.com wrote:

This error is because ports is being set to a string , but it needs to list. It should be

ports:
- "8080:8080"
Related to #129


Reply to this email directly or view it on GitHub.

@aanand
Copy link

aanand commented Mar 4, 2015

This happens when @bfirsh builds the OSX binary. It looks weird, yes, but there's nothing dangerous going on.

@dnephin
Copy link

dnephin commented Aug 24, 2015

This was fixed by #1808

@dnephin dnephin closed this as completed Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants