Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot service with an empty list of links #1086

Closed
tristan0x opened this issue Mar 10, 2015 · 2 comments
Closed

Cannot service with an empty list of links #1086

tristan0x opened this issue Mar 10, 2015 · 2 comments

Comments

@tristan0x
Copy link

The following config drives compose crazy:

service:
  build: .
  links:

Altough this is valid YAML., compose raises the following Exception: TypeError: 'NoneType' object is not iterable

This should be allowed.

@funkyfuture
Copy link

Would you expect this to work? I guess docker run -l <container> would also fail.

I think that should be tackled when validating a configuration (#129).

edit: ignore my remark, i think your PR is the better solution than throwing an error, since more flexible configuration possibilities may lead to empty lists.

@dnephin
Copy link

dnephin commented Sep 4, 2015

links: is not an empty list, it's a null list!

This is fixed by #1808 which will give a proper error message.

@dnephin dnephin closed this as completed Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants