Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: C-p C-q should 'detach' from the container #291

Closed
d11wtq opened this issue Jul 5, 2014 · 2 comments
Closed

BUG: C-p C-q should 'detach' from the container #291

d11wtq opened this issue Jul 5, 2014 · 2 comments

Comments

@d11wtq
Copy link

d11wtq commented Jul 5, 2014

Docker handles the key sequence C-p C-q as a way of detaching from the running container if you're inside a PTY. This means it closes the PTY, but leaves the container running, so you can re-attach later.

Currently if you do that in fig, you'll appear to have 'locked' your terminal until you press Ctrl-C. This is because fig includes a call to client.wait(container), which will wait indefinitely on a detached session.

I'm not 100% what the correct approach is to fix this. I'm just documenting the issue and pointing to where the problem is.

@techniq
Copy link

techniq commented Sep 18, 2014

It would be nice to have C-p C-q to detach from the container(s) after running fig up and forgetting the -d flag, or within fig logs as I don't see a way to go in and out without bringing down the environment

@dnephin
Copy link

dnephin commented Feb 3, 2016

This has been open for a while and there's been very little interest in this feature, so I think we can close this.

I think the detach from logs or up is more compelling. Might be worth opening a new issue for that. I'd personally like to make that behaviour the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants