Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't push local images #6112

Closed
FernandoMiguel opened this issue Jul 30, 2018 · 2 comments
Closed

Don't push local images #6112

FernandoMiguel opened this issue Jul 30, 2018 · 2 comments

Comments

@FernandoMiguel
Copy link

Description of the issue

We have a docker-compose.yml which is used to build many images. Some of those images also use a disposable but cacheable "builder" image.

We want to push some of those images to AWS ECR.
The only images are the non builder ones.
For example

  nginx-base:
    image: XXX.dkr.ecr.eu-west-1.amazonaws.com/nginx-base:release-production

  ms-builder:
    build:
      [...]
    image: ms-builder:release-${id}

The idea is to use
$ docker-compose -f docker-compose.base-images.yml push
and only push the ones tagged with ECR

But by default, docker will assume docker.io as the default registry, and prepend that to the images name, trying to push the builders to docker.io, leading to a fail

We have been fallbacking to --ignore-push-failures but that will not makes aware if a valid image fails to push.

Would it be possible to tag images with some prefix that would make docker push skip them?
something like local/ms-builder:release-${id}

Context information (for bug reports)

docker-compose version 1.21.1, build 5a3f1a3
docker-py version: 3.3.0
CPython version: 3.6.4
OpenSSL version: OpenSSL 1.0.2o  27 Mar 2018```

Client:
Version: 18.03.1-ce
API version: 1.37
Go version: go1.9.5
Git commit: 9ee9f40
Built: Thu Apr 26 07:13:02 2018
OS/Arch: darwin/amd64
Experimental: false
Orchestrator: swarm

Server:
Engine:
Version: 18.03.1-ce
API version: 1.37 (minimum version 1.12)
Go version: go1.9.5
Git commit: 9ee9f40
Built: Thu Apr 26 07:22:38 2018
OS/Arch: linux/amd64
Experimental: true```

@shin-
Copy link

shin- commented Jul 31, 2018

Related: #4283

docker-compose push was originally added to support application bundles (https://docs.docker.com/compose/bundles/) which we're no longer working on (supplanted by docker stack deploy and the v3 format). As such, we're likely to deprecate docker-compose push in the future, and it's unlikely we'll add new features to it.

@FernandoMiguel
Copy link
Author

I see. It saddens me.
We use Docker compose push a lot in our work flow.
Would be hard to find something as simple as this tooling.
If possible, keep supporting it at the very least as is

@shin- shin- closed this as completed Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants