Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output status on push without a TTY #6197

Closed
etienned opened this issue Sep 14, 2018 · 4 comments
Closed

Add output status on push without a TTY #6197

etienned opened this issue Sep 14, 2018 · 4 comments

Comments

@etienned
Copy link

Description of the issue

I wish docker-compose push output a status (nothing was pushed or something was pushed) even when the command is run in non-interactive mode (no TTY). It's useful, when running this command in an automation system, to know if the push really pushed something or not. Currently there's useful output (in the progress) only in interactive mode. Example:

The push refers to repository [192.168.33.12:5000/project_app]
362e0645389f: Pushed
0f11fc162618: Pushed
.9kB/123kB0f: Layer already exists
cc0a700d4a94: Layer already exists
ad60e53a05f3: Layer already exists
af42f63b4140: Layer already exists
23a28904a940: Layer already exists
1b813172f183: Layer already exists
2ae0c221ec2c: Layer already exists
9c46f426bcb7: Layer already exists
latest: digest: sha256:0a79329904f944ae3cc24d78c451d786156460b49af8ea44eea8960e7b008f6b size: 2424

An output similar the one of the pull command with the --no-parallel flag could be perfect.

docker-compose version 1.22.0, build unknown
docker-py version: 3.5.0
CPython version: 2.7.15
OpenSSL version: OpenSSL 1.0.2p  14 Aug 2018
Client:
 Version:           18.06.1-ce
 API version:       1.38
 Go version:        go1.10.3
 Git commit:        e68fc7a
 Built:             unknown-buildtime
 OS/Arch:           darwin/amd64
 Experimental:      false

Server:
 Engine:
  Version:          18.06.1-ce
  API version:      1.38 (minimum version 1.12)
  Go version:       go1.10.3
  Git commit:       e68fc7a
  Built:            Tue Aug 21 17:23:15 2018
  OS/Arch:          linux/amd64
  Experimental:     false
services:
  app:
    build:
      context: /Users/the_user/Sites/project/app
    image: 192.168.33.12:5000/project_app:latest
    ports:
    - 8088:8088/tcp
    restart: always
version: '2.1'

Steps to reproduce the issue

  1. Run docker-compose push in non-interactive mode.

Observed result

Pushing app (192.168.33.12:5000/project_app:latest)...

Expected result

Pushing app (192.168.33.12:5000/project_app:latest)...
Status: Uploaded newer image to 192.168.33.12:5000/project_app:latest

or

Pushing app (192.168.33.12:5000/project_app:latest)...
Status: Image was up to date on 192.168.33.12:5000/project_app:latest
@shin-
Copy link

shin- commented Sep 14, 2018

Hi @etienned !

As previously mentioned, push is a command that was originally designed specifically to support the now deprecated bundle files. As a result, we're unlikely to do any significant work on the command and are considering deprecating it in a future version.

@etienned
Copy link
Author

I understand your point of view but, as the others commenters of the issue you've linked, I'm wondering what's the alternative workflow for us? We are not using bundles but our stack is based on the possibility to build a compose stack locally and then push it to our private registry. It's working pretty well for us, except for the missing status on push.

@stale
Copy link

stale bot commented Oct 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 9, 2019
@stale
Copy link

stale bot commented Oct 16, 2019

This issue has been automatically closed because it had not recent activity during the stale period.

@stale stale bot closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants