Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fig cannot deal when source docker is deleted? #856

Closed
resouer opened this issue Jan 19, 2015 · 2 comments
Closed

Fig cannot deal when source docker is deleted? #856

resouer opened this issue Jan 19, 2015 · 2 comments

Comments

@resouer
Copy link

resouer commented Jan 19, 2015

If I upgrade volume source docker and use fig run to start it again, it seems intermediate container cannot deal with this porperly?

e.g.
dbdata has a volume /dbdata
db1 --volume-from dbdata

if fig use docker rm dbdata and then docker run -v /dbdata --name dbdata
db1 and dbdata will not share the same volume anymore.

And, intermediate container is responsible for record only one-way (get_volumes_from) direction?

 container.start(
            links=self._get_links(link_to_self=options.get('one_off', False)),
            port_bindings=port_bindings,
            binds=volume_bindings,
            volumes_from=self._get_volumes_from(intermediate_container),
            privileged=privileged,
@dnephin
Copy link

dnephin commented Jan 19, 2015

I'm not sure I completely understand the issue, but there's a good chance that #711 has fixed this.

I think if you do docker run -v /dbdata --name dbdata docker is not going to re-use the volume. fig handles this case and takes care of re-using the old volume.

@dnephin
Copy link

dnephin commented Sep 28, 2015

No response from OP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants