Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish images for compose v2 to dockerhub #8871

Closed
emeryao opened this issue Nov 3, 2021 · 16 comments
Closed

publish images for compose v2 to dockerhub #8871

emeryao opened this issue Nov 3, 2021 · 16 comments

Comments

@emeryao
Copy link

emeryao commented Nov 3, 2021

the image on docker hub is still at v1.29.2
could we publish the latest v2 images to dockerhub ?

It's more convenient for me to use the docker/compose image to run compose commands than downloading the compose binaries and it's also easier to keep updated with the latest docker compose version

For example I use the compose image to deploy a compose-yml

$ docker container run --rm \
    -v /var/run/docker.sock:/var/run/docker.sock \
    -v $PWD/compose.yml:/srv/compose.yml \
    docker/compose:1.29.2 \
    -f /srv/compose.yml up -d

It's so convenient that there is no need to find and download the latest binary of docker-compose and deploy it to the local machine and it's so easy to keep updated by just updating the image version

@mat007
Copy link
Member

mat007 commented Nov 3, 2021

That’s a good point, thanks for raising it!

@ciaranmcnulty
Copy link

Would be good for grabbing the binary in our own images (the same way the builds-bin ones are used)

@ndeloof ndeloof changed the title [v2] publish images for compose v2 to dockerhub publish images for compose v2 to dockerhub Nov 4, 2021
@ndeloof
Copy link
Contributor

ndeloof commented Nov 4, 2021

as a CLI plugin, why not just get compose bundled into https://hub.docker.com/_/docker ?

@ciaranmcnulty
Copy link

@ndeloof it's possible, but currently other plugins (like buildx) aren't bundled either

@johnthagen
Copy link
Contributor

as a CLI plugin, why not just get compose bundled into https://hub.docker.com/_/docker ?

@ndeloof The docs for that image don't mention compose, are you saying it is officially supported there or that it could be instead of continuing to publish a separate compose image?

@ndeloof
Copy link
Contributor

ndeloof commented Nov 15, 2021

I mean the docker image should include the CLI plugins. As @ciaranmcnulty noticed, it doesn't even includes buildx.
I don't know who's managing it

@thaJeztah
Copy link
Member

The docker image on hub includes what's bundled in the static packages from download.docker.com, which do not (yet) contain plugins.

@ndeloof
Copy link
Contributor

ndeloof commented Nov 15, 2021

@thaJeztah sure, but that's just publisher decision to do so. Could also write Dockerfile so the image includes all released CLI plugins, right?

@BlackQube
Copy link

+1
would be nice to use some features like profiles with the image

@agronholm
Copy link

Is there any blocker for this at the moment?

@daklaus
Copy link

daklaus commented Feb 16, 2022

+1 from me as well. Currently I am adding Compose v2 to the docker image with my own Dockerfile and use the resulting image as a replacement for the original docker image for docker-in-docker builds on GitLab CI/CD pipelines.

@dR3b
Copy link

dR3b commented Mar 31, 2022

Please push the image to Docker Hub now!

@johnthagen
Copy link
Contributor

Now that Docker Compose V2 is GA, could new Docker Images be pushed?

@johnthagen
Copy link
Contributor

johnthagen commented May 11, 2022

Compose v2 is included in docker:20.10.15:

@glours
Copy link
Contributor

glours commented May 11, 2022

🎉

> docker pull docker
Using default tag: latest
latest: Pulling from library/docker
9981e73032c8: Already exists
77b8a1a2bc33: Pull complete
fa25d67de920: Pull complete
f0bace62412b: Pull complete
0d8b8a1b3f8c: Pull complete
ddd73b574414: Pull complete
d1491e487ee1: Pull complete
b7428344a1d2: Pull complete
cf19d592fc22: Pull complete
Digest: sha256:d11ece2878a6f8efbced93964e6ae22aa21721bc0efd9ef2e7e28685859d49d9
Status: Downloaded newer image for docker:latest
docker.io/library/docker:latest
> docker run --rm docker docker compose version
Docker Compose version v2.5.0

@glours glours closed this as completed May 11, 2022
@emeryao
Copy link
Author

emeryao commented May 30, 2022

Hi Team

with the release of docker/compose@v2.6.0 the latest docker image I pulled from dockerhub still comes with compse@v2.5.1 so I can not get the latest compose by the method above by @glours

and IMHO it is possible to always get latest compose with image of docker/compose back in v1.x ages just by pulling the latest docker/compose images @mat007

$ docker pull docker:latest
latest: Pulling from library/docker
Digest: sha256:101f87347f4f6e14857f00f216d838399cc879791a6c6c15e00cc374c1ff55b5
Status: Image is up to date for docker:latest
docker.io/library/docker:latest
$ docker run --rm docker:latest docker compose version
Docker Compose version v2.5.1

Sorry for my poor English

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests