Skip to content

Commit ac23129

Browse files
committed
Run integration tests against multiple moby engines/api versions
Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
1 parent 20ef813 commit ac23129

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

.github/workflows/ci.yml

+16-1
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,26 @@ jobs:
4646
strategy:
4747
matrix:
4848
variant: [ "integration-dind", "integration-dind-ssl", "integration-dind-ssh" ]
49+
api-version: [1.44, 1.43, 1.42, 1.24] # 1.24 is the oldest supported version
50+
engine-version: [25.0] # latest
51+
include: # ugly repetition because GHA doesn't support lists in these objects so we need a separate entry for each variant
52+
- engine-version: 23.0 # mirantis lts
53+
api-version: 1.42
54+
variant: "integration-dind"
55+
- engine-version: 23.0 # mirantis lts
56+
api-version: 1.42
57+
variant: "integration-dind-ssl"
58+
- engine-version: 23.0 # mirantis lts
59+
api-version: 1.42
60+
variant: "integration-dind-ssh"
4961

5062
steps:
5163
- uses: actions/checkout@v4
52-
- name: make ${{ matrix.variant }}
64+
- name: ${{ matrix.variant }} - v${{ matrix.engine-version }}/v${{ matrix.api-version }}
5365
run: |
5466
docker logout
5567
rm -rf ~/.docker
5668
make ${{ matrix.variant }}
69+
env:
70+
TEST_ENGINE_VERSION: ${{ matrix.engine-version }}
71+
TEST_API_VERSION: ${{ matrix.api-version }}

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
TEST_API_VERSION ?= 1.43
2-
TEST_ENGINE_VERSION ?= 24.0
1+
TEST_API_VERSION ?= 1.44
2+
TEST_ENGINE_VERSION ?= 25.0
33

44
ifeq ($(OS),Windows_NT)
55
PLATFORM := Windows

0 commit comments

Comments
 (0)