Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip 10 build failure #1993

Closed
FRidh opened this issue Apr 14, 2018 · 6 comments
Closed

pip 10 build failure #1993

FRidh opened this issue Apr 14, 2018 · 6 comments
Milestone

Comments

@FRidh
Copy link

FRidh commented Apr 14, 2018

This package (3.2.1 and master) fails to build with pip 10.0.0:

File "setup.py", line 12, in <module>
    if 'docker-py' in [x.project_name for x in pip.get_installed_distributions()]:
AttributeError: 'module' object has no attribute 'get_installed_distributions'

The function get_installed_distributions is now part of pip._internal.

@FRidh
Copy link
Author

FRidh commented Apr 14, 2018

Note this in effect breaks moto and thereby the testing of pandas.

@TomasTomecek
Copy link
Contributor

I wonder whether function get_installed_distributions() was ever an official public API of pip.

@FRidh
Copy link
Author

FRidh commented Apr 15, 2018

No, it was not.

pypa/pip#5154 (comment)

Although by not prefixing it with an underscore it never was that obvious. Until now then.

@FRidh
Copy link
Author

FRidh commented Apr 15, 2018

Probably pkg_resources.working_set is best used here.

@adamtheturtle
Copy link
Contributor

1d6f8ec#diff-2eeaed663bd0d25b7e608891384b7298 fixes this issue but is not yet released.

@FRidh
Copy link
Author

FRidh commented Apr 21, 2018

Though not mentioned in PR or commit, a fix was merged as part of #1990.

@shin- can we get a 3.2.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants