Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting a container HostConfig when creating a container #410

Closed
wallrj opened this issue Nov 26, 2014 · 2 comments
Closed

Comments

@wallrj
Copy link

wallrj commented Nov 26, 2014

New! It is now possible to set a container's HostConfig when creating a container. Previously this was only available when starting a container.

See https://docs.docker.com/reference/api/docker_remote_api/#v115

So it would be useful if Client.create_container could accept all the HostConfig related parameters that are currently accepted by Client.start.

Meanwhile, we can construct a config dictionary and supply that to Client.create_container_from_config.

Also note:

New! Passing the container's HostConfig on start is now deprecated. You should set this when creating the container.

So there should probably be a deprecation warning when those parameters are supplied to start

But that's probably a separate issue.

@pchico83
Copy link

+1, this would mitigate #419

@shin-
Copy link
Contributor

shin- commented Dec 17, 2014

Fixed by #428 !

@shin- shin- closed this as completed Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants