Fix exec form of HEALTHCHECK CMD #26208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We attached the JSON flag to the wrong AST node, causing Docker to treat the exec form ["binary", "arg"] as if the shell form "binary arg" had been used. This failed if "ls" was not present. Added a test to detect this. Fixes moby#26174 Signed-off-by: Thomas Leonard <thomas.leonard@docker.com>
tonistiigi
added
status/2-code-review
and removed
area/distribution
status/0-triage
labels
|
LGTM |
|
Cool, thank @talex5 |
|
ping @vieux looks like this fixes a bug in 1.12, I'm adding this to the 1.12.2 milestone for consideration |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
My code for parsing the HEALTHCHECK command didn't work correctly for JSON-format commands because I was attaching the JSON flag to the wrong AST node, causing Docker to treat the exec form ["binary", "arg"] as if the shell form "binary arg" had been used. This failed if "sh" was not present. I added a test to detect the problem and fixed it.
Fixes #26174
- How to verify it
Try the example in the linked bug report.
- Description for the changelog
Fix exec form of HEALTHCHECK CMD
Signed-off-by: Thomas Leonard thomas.leonard@docker.com