Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile*: bump Go to 1.7.5 #30489

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Conversation

unclejack
Copy link
Contributor

- What I did
I've bumped the Go version to 1.7.5.

- How I did it
I've edited all the relevant files.

- How to verify it
This can be done by taking a look at the changelog.

- Description for the changelog
Dockerfile*: bump Go to 1.7.5

Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonistiigi
Copy link
Member

LGTM

@unclejack
Copy link
Contributor Author

https://jenkins.dockerproject.org/job/Docker-PRs-arm/358/console seems to have run into errors.

@thaJeztah thaJeztah added this to the 1.13.1 milestone Jan 28, 2017
@tonistiigi
Copy link
Member

Looked at some failed builds for arm-master. Found TestSwarmPublishDuplicatePorts also failing in https://jenkins.dockerproject.org/job/Docker-PRs-arm/359/console . Didn't see TestLogsFollowSlowStdoutConsumer but we've had trouble with this test before in #29030

@tiborvass
Copy link
Contributor

@tonistiigi is the issue with master or with this PR ? If it is only with master I think we should merge this.

@tonistiigi
Copy link
Member

@tiborvass As I wrote I found one case where one of the failed tests failed in master and the other test failed in another PR(although that pr also updates go). I would say it is likely that the problem is not in this PR but hard to be 100% certain.

@tiborvass tiborvass merged commit a88e529 into moby:master Jan 30, 2017
@vieux vieux mentioned this pull request Jan 30, 2017
@unclejack unclejack deleted the bump_go_to_1.7.5 branch February 15, 2017 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants