This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[18.09 backport] Makes a few modifications to the name generator. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replaces `cocks` with `cerf` as the former might be perceived as offensive by some people (as pointed out by @jeking3 [here](moby#37157 (comment))) * Removes a duplicate entry for `burnell` * Re-arranges the entry for `sutherland` to ensure that the names are in sorted order * Adds entries for `shamir` and `wilbur` Signed-off-by: Debayan De <debayande@users.noreply.github.com> (cherry picked from commit e50f791) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @justincormack @mbentley @andrewhsu PTAL |
|
Thanks @thaJeztah. It makes sense when understanding that the casual user doesn’t have the context of why particular names are included in the name generator so the possible results should, unfortunately, be taken into account. |
justincormack
approved these changes
Feb 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of moby#38422 for 18.09. A bit unfortunate, but the inclusion of Clifford Christopher Cocks raised some eyebrows among users and customers, so let's backport this one
cockswithcerfas the former might be perceived asoffensive by some people (as pointed out by @jeking3
here)
burnellsutherlandto ensure that the names are insorted order
shamirandwilburSigned-off-by: Debayan De debayande@users.noreply.github.com
(cherry picked from commit e50f791)
Signed-off-by: Sebastiaan van Stijn github@gone.nl
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)