Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[18.06] LCOW: Prefer Windows over Linux in a manifest list #3

Conversation

thaJeztah
Copy link
Member

When a manifest list contains both Linux and Windows images, always
prefer Windows when the platform OS is unspecified. Also, filter out any
Windows images with a higher build than the host, since they cannot run.

cherry picked from commit ddcdb72 (moby#37369) - no conflicts

@thaJeztah thaJeztah added this to the 18.06.0 milestone Jun 29, 2018
When a manifest list contains both Linux and Windows images, always
prefer Windows when the platform OS is unspecified. Also, filter out any
Windows images with a higher build than the host, since they cannot run.

Signed-off-by: John Stephens <johnstep@docker.com>
(cherry picked from commit ddcdb72)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 18.06-backport-update-windows-manifest-sorting branch from 6fbf69c to 605cc35 Compare July 3, 2018 20:24
@thaJeztah
Copy link
Member Author

ping @johnstep @dmcgowan PTAL

Copy link

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit cba8083 into docker-archive:18.06 Jul 5, 2018
@thaJeztah thaJeztah deleted the 18.06-backport-update-windows-manifest-sorting branch July 5, 2018 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants