-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permissions on for files mounted with Mutagen-based caching #4593
Comments
Also confirmed with an Alpine container: Test: Looking in |
Thanks for the report! I've got an experimental build you could try: https://desktop-stage.docker.com/mac/edge/45418/Docker.dmg -- it has 2 changes:
Let me know if that helps at all. |
Confirmed this fixes the problem! @djs55 could you please release a signed copy of this release so I can continue testing without disabling gatekeeper? |
@chezsmithy I've notarized another testing build: https://desktop-stage.docker.com/mac/edge/45429/Docker.dmg . This one should have the permissions change and the |
Thank you so much @djs55 for quick response. Random question, i've noticed that while caching/indexing is in the progress, i cannot start containers which want to mount stuff from those locations (make sense). Are there plans for improving visibility into that? Also is there any good place where i can find more information how Mutagen-based caching works, what's different and is it better than before other than https://docs.docker.com/docker-for-mac/mutagen-caching/ ? |
@rastasheep - there's a lot on Mutagens website https://mutagen.io/documentation/introduction - including their initial Docker implementation https://mutagen.io/documentation/transports/docker . Will be interesting to learn how that was absorbed into Docker for Mac. |
I have been using Mutagen for a little bit and my initial reaction is fairly impressed. |
After some time using it on real project, i can notice great improvements on |
Agreed, same here for database migrations with heavy file access, probably 3x faster than previously |
Im still having permissions issues with 2.3.1.0 (45429) Edit: I deleted the cache, removed the containers, switched the cache back on then rebuilt containers and now it works fine. |
45429 worked for me with Drupal 8 (PHP, Symfony3) project. When I synced data from live environment, I got following kind errors from Drush (cli tool for Drupal) related to every folder in rsynced paths:
Drush uses rsync to sync uploaded files and it seems to have some permission problems. I need to test it further. |
@back-2-95 did you download the updated notarized build from the comments above? This build fixed my file permission issues. |
@djs55 could you let us know when your fix goes into the Edge release ? |
@jasonwilliams here is an updated edge release which is notarized. I am running this release without issue now. |
@chezsmithy to your question 2 days ago: yes, I used updated notarized build (45429) |
@djs55 has your fix gone into the mainline (edge) build, or do we still need to download your patch to fix the permissions issues?
@chezsmithy That's not what i meant, I meant do we still need to download the specific notarized build or can we use the edge release now |
@back-2-95 , I actually got that a couple of times as well.. I had that issue when I was mounting a lot of file, I also may have ran out of disk space for docker as well. If I remember right how I resolved it was to:
I do wish we could see what the actual error was.. |
It would be nice if we could somehow specify permission and other sync-related configurations for each mount as well. Something like this would allow us a lot of power in setting owning users/groups as well as the countless other number of options Mutagen lets us tweak. Even if we have a per-project |
For those using the mutagen.yml to fix the permissions issue, what does the format of your |
@jasonwilliams I use this structure, i hope you find it useful.
If you don't know your group or user id, try to enter in your container and type easily |
Since switching to the latest edge 2.3.4.0 and using the mutagen.yml ive not had much luck at all. I've tried clearing volumes and purging data etc. I will have to go back to @djs55 specific build or back to Stable :( Edit: it looks like switching to |
Hi everyone, and thank you for all your feedback. I'm going to close this ticket because in the latest Edge release we have removed Mutagen for the moment while we reconsider a lot of the UX issues, such as those mentioned above. Instead we have made some big file sharing performance improvements by removing osxfs and using gRPC-FUSE instead (by default). The full explanation is at #1592 (comment), so please read that for more details. |
Closed issues are locked after 30 days of inactivity. If you have found a problem that seems similar to this, please open a new issue. Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows. |
Information
I'm using docker-compose to mount files into container which is run with root user (official node image with
node
user).When I set up Mutagen based caching, my non root user doesn't have permissions to edit mounted files. Without caching enabled mounted files are owned by that non root user.
Here is service definition from docker-compose:
File permissions without caching
File permissions with Mutagen-based caching
The text was updated successfully, but these errors were encountered: