Arguments no longer encoded in ENTRYPOINT when using shell-form with an exec-form SHELL

[heaths]

In the latest stable version 19.03.1 a user found a problem when building a Dockerfile that uses an exec-form SHELL with a shell-form ENTRYPOINT, which was working up to an including version 18.09.3:

SHELL ["cmd", "/S", "/C"]
# ...
ENTRYPOINT C:\BuildTools\Common7\Tools\VsDevCmd.bat &&

When inspecting the current image, seems ArgsEscaped is missing, which in version 18.09.3 was "ArgsEscaped": true. See https://github.com/MicrosoftDocs/visualstudio-docs/issues/3713 for details.

[mikeparker]

Ok i've been looking into this, i am fairly sure this is not a Desktop issue, and rather a docker engine issue, so you probably want github.com/moby/moby

Some history around this, probably related to https://github.com/moby/moby/pull/38541/files
And there was a spec change which changes how arguments get escaped here opencontainers/runtime-spec#998

Out of curiosity, whats the && for at the end of the command line?

[heaths]

Thanks for finding that. I thought it might be more of an engine issue but typically have been asked to open issues here first. That said, I know @jhowardmsft and will ask him for more context and suggested fixes/workarounds.

We need to start the vsdevcmd.bat environment initialization script (mainly updates the PATH environment variable with installed toolset paths) before we run anything, sot he && means, "if that worked, then run the given command".

[docker-robott]

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked