This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Carry #74 Expose Interpolate for external tools #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is quite useful to parse a text file in the same exact way that compose does. One can imagine this being useful for GUI applications or custom parsers. Signed-off-by: Darren Shepherd <darren@rancher.com> Conflicts: project/merge.go
| type rawService map[string]interface{} | ||
| type rawServiceMap map[string]rawService | ||
| // RawService is represent a Service in map form unparsed | ||
| type RawService map[string]interface{} |
There was a problem hiding this comment.
When moving to a config package, I think we should use a more abstracted name 😝
|
@joshwget you beat me to it 👍 😉 |
|
LGTM 🐯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed a few new instances of
rawServiceandrawServiceMap. As discussed in #99, interpolation will be moved into aconfigpackage separately from this PR.It is quite useful to parse a text file in the same exact way that
compose does. One can imagine this being useful for GUI applications or
custom parsers.
Signed-off-by: Darren Shepherd darren@rancher.com
Conflicts:
project/merge.go