Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name the ingress sandbox explicitly #1449

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Name the ingress sandbox explicitly #1449

merged 1 commit into from
Sep 20, 2016

Conversation

sanimej
Copy link

@sanimej sanimej commented Sep 15, 2016

For ease of debugging the ingress sandbox should have a fixed name that doesn't change.

This PR sets it explicitly in libnetwork. An alternative would be to use the container id ingress-sandbox which is passed to the sandbox creation. But the presence of - is currently interpreted as overlay network sandbox.

Signed-off-by: Santhosh Manohar santhosh@docker.com

Signed-off-by: Santhosh Manohar <santhosh@docker.com>
@mrjana
Copy link
Contributor

mrjana commented Sep 15, 2016

LGTM

1 similar comment
@aboch
Copy link
Contributor

aboch commented Sep 16, 2016

LGTM

@mrjana mrjana merged commit d271945 into moby:master Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants