Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for azure/login@v2? #700

Open
andrasg opened this issue Apr 21, 2024 · 1 comment
Open

Support for azure/login@v2? #700

andrasg opened this issue Apr 21, 2024 · 1 comment

Comments

@andrasg
Copy link

andrasg commented Apr 21, 2024

Description

I am trying to push to an Azure Container Registry using azure/login@v2.

I have successfully setup federated workload identities auth using: Configure a federated identity credential on an app

      - name: Azure login
        uses: azure/login@v2
        with:
          client-id: ${{ secrets.AZURE_CLIENT_ID }}
          tenant-id: ${{ secrets.AZURE_TENANT_ID }}
          subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

The above task successfully authenticates to Azure. I am unsure though how docker/login-action@v3 would be able to pick up the authenticated context. Is this supported? If not, would be a great addition.

nb: auth to ACR using username+password works great:

      - name: 'Docker login'
        uses: docker/login-action@v3
        with:
          registry: ${{ secrets.ACR_REGISTRY }}
          username: ${{ secrets.ACR_USERNAME }}
          password: ${{ secrets.ACR_PASSWORD }}
@lgmorand
Copy link

@andrasg are you using docker credentials (or SPN) ?

with docker admin credentials, I get

unauthorized: Application not registered with AAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants