Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add retries for 502 #803

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add retries for 502 #803

wants to merge 4 commits into from

Conversation

fedordikarev
Copy link

Fix: #750

  • Retry only 5xx errors (502 for now) as dont need to retry bad login/passwords
  • Sleep 10s before attempts. It could be configurable, but shouldn't bit less than 10s.
  • Delay could be with exponential backoff, or just simple approach with no more than 3 attempts and constant 10s delay, IMO, should be enough for docker login

@fedordikarev
add retries for 502
8479e90 
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
@fedordikarev
trim stderr for checking
162c32c 
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
@fedordikarev
add attempts to the action.yml
ca362a5 
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
offensive-vk
offensive-vk reviewed Oct 30, 2024
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@fedordikarev
mistype
087884b 
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
@fedordikarev
Copy link
Author

hi @crazy-max !

what do you think about these changes?

@bayandin bayandin mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offensive-vk offensive-vk offensive-vk left review comments

@crazy-max crazy-max Awaiting requested review from crazy-max

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add retry
2 participants
@fedordikarev @offensive-vk