Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: post release cleanup #126

Merged
merged 3 commits into from
Nov 19, 2020
Merged

chore: post release cleanup #126

merged 3 commits into from
Nov 19, 2020

Conversation

sy-records
Copy link
Member

@sy-records sy-records commented Nov 17, 2020

  • Update test snapshots.
  • Add postbump lifecycle script to update test snapshots after version bump.

@jamesgeorge007 jamesgeorge007 changed the title test: release v4.4.2 test: update snapshots Nov 17, 2020
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following to package.json:-

"standard-version": {
    "scripts": {
      "prerelease": "ava e2e/cli.test.js -u"
    }
  },

@sy-records
Copy link
Member Author

This is not what I was expecting...

Ava needs to be executed here to update the screenshot, otherwise it is still the old version.

image

If it's not supported, it has to be done manually 🤣

@jamesgeorge007
Copy link
Member

jamesgeorge007 commented Nov 18, 2020

It seems the postbump lifecycle script would do the job.

-    "release": "standard-version"
+    "release": "standard-version -a"
+  },
+  "standard-version": {
+    "scripts": {
+      "postbump": "ava e2e/cli.test.js -u && git add ."
+     }
+  },

Screenshot 2020-11-18 at 9 04 41 AM

@sy-records
Copy link
Member Author

Thanks, you're right! 👍🏻

@jamesgeorge007 jamesgeorge007 changed the title test: update snapshots chore: post release cleanup Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants