Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request for Vue theme - configure font size #1158

Closed
alexellis opened this issue May 5, 2020 · 3 comments
Closed

Feature request for Vue theme - configure font size #1158

alexellis opened this issue May 5, 2020 · 3 comments
Labels

Comments

@alexellis
Copy link

Feature request

I searched StackOverflow and couldn't find any references to this, but it is mentioned in the roadmap under #657

So far docsify has been very helpful in getting up a quick docs site for https://inlets.dev/ but I find the font size rather small when viewed at 100% zoom, especially the body and nav-bar.

I have found a few links on Google such as this one however it doesn't appear to work with the Vue theme.

I'd like to see in the docs instructions for increasing the font scaling for the default theme. 18pt appears to render at a more readable size.

Compare the two screenshots (one with default text on GitHub and one with the default docsify theme for context)

Screenshot 2020-05-05 at 10 46 05

Screenshot 2020-05-05 at 10 46 01

What are your thoughts on the suggestion?

@anikethsaha
Copy link
Member

Thanks for the issue.

I dont have experience with vue so maybe some else can pick this.
about the default font size, I think we can consider that to be increased as there are other issue as well for this #1196

PR welcome for the default style. Or we can add it as a css variable.

@stale
Copy link

stale bot commented Jul 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 24, 2020
@anikethsaha anikethsaha added pinned This is to pinned the PR/Issue in order to keep it open and removed wontfix labels Jul 25, 2020
@jhildenbiddle jhildenbiddle changed the title Feature request for Vue template - configure font size Feature request for Vue theme - configure font size Oct 7, 2020
@jhildenbiddle
Copy link
Member

I believe @alexellis is referring the the vue theme, not a Vue.js template. I have updated the title accordingly (let me know if I have this wrong).

A few options:

  1. Override the style declarations in vue.css. The theme isn't setup to do this easily, so you'll have to override several rules. Here's a quick-and-dirty example:

    <style>
      html {
        font-size: 18px;
      }
    
      body,
      .app-nav li ul li,
      .sidebar ul li a,
      input[type='search'] {
        font-size: 1em;
      }
    </style>
  2. Use docsify-themeable instead of vue.css. The base font size is set to 16px by default, but you can easily the CSS custom property that controls this:

    <style>
      :root {
        --base-font-size: 18px
      }
    </style>
  3. Wait for docsify v5, which (according to current plans) will integrate docsify-themeable. A vue.css-like option will be available, but it will be built using docsify-themeable.

@jhildenbiddle jhildenbiddle added question and removed pinned This is to pinned the PR/Issue in order to keep it open labels Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants