Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hash # symbol from URLs? #1479

Closed
shawaj opened this issue Jan 18, 2021 · 7 comments
Closed

Remove hash # symbol from URLs? #1479

shawaj opened this issue Jan 18, 2021 · 7 comments
Labels

Comments

@shawaj
Copy link

shawaj commented Jan 18, 2021

Feature request

It's it possible to remove the # from the URLs?

Like https://helium.nebra.com/#/indoor-hotspot/overview change to https://helium.nebra.com/indoor-hotspot/overview ?

What problem does this feature solve?

Better looking URLs

What does the proposed API look like?

N/A

How should this be implemented in your opinion?

Simple config change

Are you willing to work on this yourself?

Yes but don't know if I have the ability.

@sy-records
Copy link
Member

you can see #235

@shawaj
Copy link
Author

shawaj commented Jan 18, 2021

@sy-records it doesn't seem to provide a solution?

@sy-records
Copy link
Member

#235 (comment)

@shawaj
Copy link
Author

shawaj commented Jan 18, 2021

What is HTML5 history API?

And does it cause any other problems with the setup if using github pages?

@Koooooo-7
Copy link
Member

What is HTML5 history API?

And does it cause any other problems with the setup if using github pages?

The # makes the hash router.
History model uses history.pushState to change urls, it like the normal urls without #.
This model needs a server to avoid 404 error on flushing page, so ,u cant use it on github pages.
More details see HTML5 History Mode.

@shawaj
Copy link
Author

shawaj commented Jan 18, 2021

Thanks @Koooooo-7 very helpful. So must use a different server not github pages?

@shawaj
Copy link
Author

shawaj commented Jan 18, 2021

All sorted thanks @Koooooo-7 @sy-records https://helium.nebra.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants