Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace ES6 usage for IE11 compatibility #1500

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Conversation

jhildenbiddle
Copy link
Member

Summary

  • Replace template literals
  • Replace Object.entries
  • Replace Object.assign
  • Replace method shorthand (e.g. { foo() {} } vs { foo: function() {} })

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Code style update

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Feb 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/oseva31ft
✅ Preview: https://docsify-preview-git-fix-es6-ie11.docsify-core.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f04f9a:

Sandbox Source
docsify-template Configuration

@jhildenbiddle jhildenbiddle requested a review from a team February 8, 2021 21:46
@Koooooo-7 Koooooo-7 requested a review from a team February 9, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants