Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Improve Positioning of the Hamburger Menu on Mobile #2205

Closed
RitaDee opened this issue Aug 31, 2023 · 2 comments · Fixed by #2469
Closed

Feature request: Improve Positioning of the Hamburger Menu on Mobile #2205

RitaDee opened this issue Aug 31, 2023 · 2 comments · Fixed by #2469

Comments

@RitaDee
Copy link

RitaDee commented Aug 31, 2023

Feature request

Problem or desire

The hamburger menu is positioned at the bottom of the page in mobile view:

44474F6F-69CA-4912-BE71-3BDFEE8EE256

image

Steps to reproduce

  1. Visit https://intro.opensauced.pizza/ on mobile.

Proposal

IMHO I suggest it should be fixed at the top.

Reasons:

  • For easy navigation.
  • For visibility(Newcomers might find it difficult to locate the hamburger menu as I did and this is because most people are used to top positioned menu).

Implementation

This request is generated from the issue: open-sauced/intro#31

@RitaDee RitaDee changed the title Wrong Positioning of the Hamburger Menu on Mobile Feature: Improve Positioning of the Hamburger Menu on Mobile Aug 31, 2023
@RitaDee RitaDee changed the title Feature: Improve Positioning of the Hamburger Menu on Mobile Feature request: Improve Positioning of the Hamburger Menu on Mobile Aug 31, 2023
@Koooooo-7
Copy link
Member

Koooooo-7 commented Sep 1, 2023

Hi @RitaDee , this is more like the personal style stuff here, I think we won't change the default behavior in docsify for now.
Maybe we could raise a config such as sidebar position [top, bottom, middle] or something in the future.

And for the requirement you mentioned here, I think you could custom some style on the sidebar or you can use this docsify-themeable to achieve it, especially the simple-dark based on the style of ur neat site.

@Koooooo-7 Koooooo-7 moved this to Todo in HELP WANTED LIST Sep 1, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in HELP WANTED LIST Dec 1, 2023
@jhildenbiddle jhildenbiddle reopened this Dec 1, 2023
@jhildenbiddle jhildenbiddle moved this from Done to Todo in HELP WANTED LIST Dec 1, 2023
@jhildenbiddle jhildenbiddle added this to the 5.x milestone Jun 16, 2024
@jhildenbiddle jhildenbiddle self-assigned this Jun 16, 2024
@jhildenbiddle jhildenbiddle linked a pull request Jul 19, 2024 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in HELP WANTED LIST Jul 19, 2024
@jhildenbiddle
Copy link
Member

This issue has been addressed by PR #2469. The changes will be available when Docsify v5 is released.

The new default sidebar position is in the middle of the left edge of the screen (red arrow). Docsify v5's new custom theme properties and optional class names make it easy to reposition the toggle (green arrows), change the toggle icon, change the colors, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants