Skip to content

Commit

Permalink
Suppress doctrine/collections related deprecations
Browse files Browse the repository at this point in the history
We are correctly triggering these indirect issues

```
Remaining indirect deprecation notices (5)

  1x: Method "ArrayAccess::offsetExists()" might add "bool" as a native return type declaration in the future. Do the same in implementation "Doctrine\Common\Collections\ArrayCollection" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in ServiceRepositoryTest::testRepositoryServiceWiring from Doctrine\Bundle\DoctrineBundle\Tests

  1x: Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Doctrine\Common\Collections\ArrayCollection" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in ServiceRepositoryTest::testRepositoryServiceWiring from Doctrine\Bundle\DoctrineBundle\Tests

  1x: Method "ArrayAccess::offsetSet()" might add "void" as a native return type declaration in the future. Do the same in implementation "Doctrine\Common\Collections\ArrayCollection" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in ServiceRepositoryTest::testRepositoryServiceWiring from Doctrine\Bundle\DoctrineBundle\Tests

  1x: Method "ArrayAccess::offsetUnset()" might add "void" as a native return type declaration in the future. Do the same in implementation "Doctrine\Common\Collections\ArrayCollection" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in ServiceRepositoryTest::testRepositoryServiceWiring from Doctrine\Bundle\DoctrineBundle\Tests

  1x: Method "Countable::count()" might add "int" as a native return type declaration in the future. Do the same in implementation "Doctrine\Common\Collections\ArrayCollection" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in ServiceRepositoryTest::testRepositoryServiceWiring from Doctrine\Bundle\DoctrineBundle\Tests
```
  • Loading branch information
ostrolucky committed Oct 9, 2022
1 parent 06ab798 commit 23c23c7
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/test-dev-stability.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ jobs:
runs-on: "ubuntu-20.04"
env:
SYMFONY_REQUIRE: ${{matrix.symfony-require}}
SYMFONY_DEPRECATIONS_HELPER: ${{matrix.symfony-deprecations-helper}}

strategy:
fail-fast: false
Expand All @@ -25,8 +24,6 @@ jobs:
symfony-require:
- ""
- "6.*"
symfony-deprecations-helper:
- ""

steps:
- name: "Checkout"
Expand Down
2 changes: 2 additions & 0 deletions Tests/baseline-ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
%Method "ArrayAccess::(offsetExists|offsetGet|offsetSet|offsetUnset)+\(\)" might add "\w+" as a native return type declaration in the future. Do the same in implementation "Doctrine\\\Common\\Collections\\ArrayCollection" now to avoid errors or add an explicit @return annotation to suppress this message\.%
%Method "Countable::count\(\)" might add "int" as a native return type declaration in the future. Do the same in implementation "Doctrine\\Common\\Collections\\ArrayCollection" now to avoid errors or add an explicit @return annotation to suppress this message\.%
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"psalm/plugin-phpunit": "^0.16.1",
"psalm/plugin-symfony": "^3",
"psr/log": "^1.1.4 || ^2.0 || ^3.0",
"symfony/phpunit-bridge": "^6.0",
"symfony/phpunit-bridge": "^6.1",
"symfony/property-info": "^4.4 || ^5.4 || ^6.0",
"symfony/proxy-manager-bridge": "^4.4 || ^5.4 || ^6.0",
"symfony/security-bundle": "^4.4 || ^5.4 || ^6.0",
Expand Down
4 changes: 4 additions & 0 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
</testsuite>
</testsuites>

<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="ignoreFile=./tests/baseline-ignore"/>
</php>

<filter>
<whitelist>
<directory>.</directory>
Expand Down

0 comments on commit 23c23c7

Please sign in to comment.