Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Document the additional form field types #312

Closed
johnpancoast opened this issue Sep 29, 2015 · 14 comments · Fixed by #535
Closed

Documentation: Document the additional form field types #312

johnpancoast opened this issue Sep 29, 2015 · 14 comments · Fixed by #535
Labels
Documentation Hacktoberfest Good issue for participating in Hacktoberfest

Comments

@johnpancoast
Copy link

johnpancoast commented Sep 29, 2015

This bundle includes an additional form type document to be used in place of entity that isn't documented anywhere from what I can tell. The only way I found it was from reviewing code, stackoverflow, and what seems like common knowledge for people at this point but that doesn't help the new people.

There may be other types I'm unaware of and I believe it includes additional data transformers too.

Where can I help?

[edited for clarity, think there's only the one additional type among other things]

@malarzm
Copy link
Member

malarzm commented Sep 29, 2015

From what I see there was supposed to be a chapter about it on http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html#learn-more-from-the-cookbook but for some reason it's not there 👶 Maybe we should create a chapter about integrations in ODM's documentation? @jmikola what do you think?

@johnpancoast
Copy link
Author

Yea I noticed that and you can actually go to http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/form in browser. But that page doesn't have enough info on the additional form types.

@malarzm
Copy link
Member

malarzm commented Sep 30, 2015

@shideon feel free to make a PR against this repo, docs are located in https://github.com/doctrine/DoctrineMongoDBBundle/tree/master/Resources/doc and surely can use some attention :)

@johnpancoast
Copy link
Author

I'll have a look when I can.

@jwage jwage added the Hacktoberfest Good issue for participating in Hacktoberfest label Oct 2, 2018
@stale
Copy link

stale bot commented Jan 21, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Jan 21, 2019
@malarzm
Copy link
Member

malarzm commented Jan 22, 2019

I still think we should document this somehow

@stale stale bot removed the Stale Issues that have not seen any activity in 30 days label Jan 22, 2019
@johnpancoast
Copy link
Author

johnpancoast commented Jan 22, 2019

Apologies everyone. I know it's the same old tired excuse. As always, I try to commit to these things, but I've been all over the place with several other projects, including music and other things. I know that others are in the same boat and they're still able to help out so it's a poor excuse, but that's just the reality for me at the moment.

Agree with @malarzm, this should absolutely be documented from what I remember. I'll check out the docs later this week unless someone else beats me to it. Committed!

@malarzm
Copy link
Member

malarzm commented Jan 22, 2019

@johnpancoast thanks a lot!

@alcaeus
Copy link
Member

alcaeus commented Jan 23, 2019

@johnpancoast don't worry about it, thanks for still giving it a shot. Let us know if you can't make it as we'll be doing a docs pass before the next round of releases to finally get some of these undocumented features documented better.

@johnpancoast
Copy link
Author

johnpancoast commented Jan 28, 2019

@malarzm and @alcaeus, thanks for understanding. This week was more of the same along with a minor 🚲 accident over the weekend (I'm fine, but was painful)! Needless to say, I did not get to this.

Let us know if you can't make it as we'll be doing a docs pass before the next round of releases

@alcaeus, when were these releases planned?

@alcaeus
Copy link
Member

alcaeus commented Jan 29, 2019

We're currently at Beta-1 with a few fixes still coming up. No fixed timeline, but I'm guessing we'll need another month or two.

@johnpancoast
Copy link
Author

johnpancoast commented Feb 15, 2019

Hmm, so TBH, I don't think there needs to be much added to the docs. Perhaps something as simple as:

Note that this bundle adds a new form type called document which is functionally equivalent to the entity form type except that it loads options from a Doctrine ODM Document instead of a Doctrine Entity.

I'm just not sure where I should add that. Thoughts?

@alcaeus
Copy link
Member

alcaeus commented Feb 18, 2019

You can add a form section to the main documentation (https://github.com/doctrine/DoctrineMongoDBBundle/blob/master/Resources/doc/index.rst). It's already quite busy so we'll have to rewrite it sooner or later, but for now I think it's best to mention it there.

@malarzm
Copy link
Member

malarzm commented Feb 18, 2019

FWIW I started splitting the docs yesterday as the index is way too huge.

@malarzm malarzm mentioned this issue Feb 20, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Hacktoberfest Good issue for participating in Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants