Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract fixture loading command to separate bundle #509

Open
alcaeus opened this issue Dec 4, 2018 · 4 comments
Open

Extract fixture loading command to separate bundle #509

alcaeus opened this issue Dec 4, 2018 · 4 comments

Comments

@alcaeus
Copy link
Member

alcaeus commented Dec 4, 2018

To better separate concerns and keep track of dependencies, we should extract the LoadDataFixturesDoctrineODMCommand to a separate bundle and release it as a separate package (comparable to DoctrineBundle and DoctrineFixturesBundle).

@malarzm
Copy link
Member

malarzm commented Dec 4, 2018

While reason is plausible, I'm not sure extracting a single command to a bundle is the best course of action.

Offhand, https://github.com/doctrine/DoctrineFixturesBundle is mentioning ODM in the readme, does that bundle support ODM already?

@jwage
Copy link
Member

jwage commented Dec 5, 2018

Yes, I believe so.

@alcaeus
Copy link
Member Author

alcaeus commented Dec 5, 2018

At the moment, the bundle does not support ODM - I'll check if it can easily be changed to do so. The reason I want to extract it is to have a purpose-built bundle that integrates mongodb-odm and data-fixtures. At this stage, you see the command but can't run it unless you know that you have to require data-fixtures as well.

@stale
Copy link

stale bot commented Jan 21, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Jan 21, 2019
@stale stale bot closed this as completed Jan 28, 2019
@alcaeus alcaeus removed the Stale Issues that have not seen any activity in 30 days label Jan 29, 2019
@alcaeus alcaeus reopened this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants