Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBAL-1130 #784 Connection is not lazy anymore, since platform detection was introduced - exposing the issue via broken test #1072

Closed
doctrinebot opened this issue Jan 23, 2015 · 2 comments

Comments

@doctrinebot
Copy link

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of weaverryan:

Url: #784

Message:

Hi guys!

This is not meant to be merged, at least not yet. The test added in #691 is flawed. It's failing NOT because there is an exception when trying to use a closed connection (in fact, if the connection is closed, it simply re-opens), but instead, the exception is:

Access denied for user 'root'@'localhost' (using password: YES)

The tests should show this. The reason is that we're using connection parameters at the top of this class (https://github.com/doctrine/dbal/blob/master/tests/Doctrine/Tests/DBAL/ConnectionTest.php#L19) that, until now, were never used to *actually* connect to the database. But now, they are being used to connect to the database, but they're incorrect - they should be pulling from TestUtil.

So, this test needs to be fixed or removed.

Thanks!

@deeky666
Copy link
Member

Fixed in #784

@Ocramius Ocramius changed the title DBAL-1130: [GH-784] "Breaking" a test temporarily to show that it's not doing what is expect... DBAL-1130 #784 Connection is not lazy anymore, since platform detection was introduced - exposing the issue via broken tes Jul 22, 2017
@Ocramius Ocramius changed the title DBAL-1130 #784 Connection is not lazy anymore, since platform detection was introduced - exposing the issue via broken tes DBAL-1130 #784 Connection is not lazy anymore, since platform detection was introduced - exposing the issue via broken test Jul 22, 2017
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants