You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is not meant to be merged, at least not yet. The test added in #691 is flawed. It's failing NOT because there is an exception when trying to use a closed connection (in fact, if the connection is closed, it simply re-opens), but instead, the exception is:
Access denied for user 'root'@'localhost' (using password: YES)
Ocramius
changed the title
DBAL-1130: [GH-784] "Breaking" a test temporarily to show that it's not doing what is expect...
DBAL-1130 #784 Connection is not lazy anymore, since platform detection was introduced - exposing the issue via broken tes
Jul 22, 2017
Ocramius
changed the title
DBAL-1130 #784 Connection is not lazy anymore, since platform detection was introduced - exposing the issue via broken tes
DBAL-1130 #784 Connection is not lazy anymore, since platform detection was introduced - exposing the issue via broken test
Jul 22, 2017
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of weaverryan:
Url: #784
Message:
Hi guys!
This is not meant to be merged, at least not yet. The test added in #691 is flawed. It's failing NOT because there is an exception when trying to use a closed connection (in fact, if the connection is closed, it simply re-opens), but instead, the exception is:
The tests should show this. The reason is that we're using connection parameters at the top of this class (https://github.com/doctrine/dbal/blob/master/tests/Doctrine/Tests/DBAL/ConnectionTest.php#L19) that, until now, were never used to *actually* connect to the database. But now, they are being used to connect to the database, but they're incorrect - they should be pulling from
TestUtil
.So, this test needs to be fixed or removed.
Thanks!
The text was updated successfully, but these errors were encountered: