Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBAL-1167 #814 allow serverVersion to be explicitly unspecified (null) #1109

Closed
doctrinebot opened this issue Mar 9, 2015 · 2 comments · Fixed by #2671
Closed

DBAL-1167 #814 allow serverVersion to be explicitly unspecified (null) #1109

doctrinebot opened this issue Mar 9, 2015 · 2 comments · Fixed by #2671
Assignees
Milestone

Comments

@doctrinebot
Copy link

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of BreiteSeite:

Url: #814

Message:

Hi,

this PR allows serverVersionto be nullable.

We use doctrine/dbal in Integration-Tests and to prevent the unit-tests from connecting to a database, we specify serverVersion with something made-up (like 5.6).

However, i'm not comfortable set serverVersion to a made-up server-version to prevent connections from being made, when there even isn't a server to connect to. With this PR merged, we could specify serverVersion to be null instead of something like 5.6 and still prevent connections from being made. null is a valid return value for getDatabasePlatformVersion().

@Ocramius
Copy link
Member

Handled in #2671

@Ocramius Ocramius changed the title DBAL-1167: [GH-814] allow serverVersion to be unspecified DBAL-1167 #814 allow serverVersion to be unspecified, and instead be detected implicitly Jul 22, 2017
@Ocramius Ocramius changed the title DBAL-1167 #814 allow serverVersion to be unspecified, and instead be detected implicitly DBAL-1167 #814 allow serverVersion to be explicitly unspecified (null) Jul 22, 2017
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants