You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We use doctrine/dbal in Integration-Tests and to prevent the unit-tests from connecting to a database, we specify serverVersion with something made-up (like 5.6).
However, i'm not comfortable set serverVersion to a made-up server-version to prevent connections from being made, when there even isn't a server to connect to. With this PR merged, we could specify serverVersion to be null instead of something like 5.6 and still prevent connections from being made. null is a valid return value for getDatabasePlatformVersion().
The text was updated successfully, but these errors were encountered:
Ocramius
changed the title
DBAL-1167: [GH-814] allow serverVersion to be unspecified
DBAL-1167 #814 allow serverVersion to be unspecified, and instead be detected implicitly
Jul 22, 2017
Ocramius
changed the title
DBAL-1167 #814 allow serverVersion to be unspecified, and instead be detected implicitly
DBAL-1167 #814 allow serverVersion to be explicitly unspecified (null)
Jul 22, 2017
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of BreiteSeite:
Url: #814
Message:
Hi,
this PR allows
serverVersion
to be nullable.We use doctrine/dbal in Integration-Tests and to prevent the unit-tests from connecting to a database, we specify
serverVersion
with something made-up (like5.6
).However, i'm not comfortable set
serverVersion
to a made-up server-version to prevent connections from being made, when there even isn't a server to connect to. With this PR merged, we could specifyserverVersion
to benull
instead of something like5.6
and still prevent connections from being made.null
is a valid return value forgetDatabasePlatformVersion()
.The text was updated successfully, but these errors were encountered: