CreateSavepoint method does not connect automatically to the database

[tezvi]

Bug Report

Q	A
BC Break	no
Version	2.9.1

Summary

When executing createSavepoint method on Connection instance PHP halts with null reference exception. The connection was not previously established.

Current behaviour

When executing Doctrine\DBAL\Connection::createSavepoint without previously issued queries or opened transaction an error occurs: "Call to a member function exec() on null".

dbal/lib/Doctrine/DBAL/Connection.php

Line 1386 in 9b88bf3

$this->_conn->exec($this->platform->createSavePoint($savepoint));

How to reproduce

Make sure to call Doctrine\DBAL\Connection::createSavepoint when no connection was previously established.

Expected behaviour

The method should explicitly call Doctrine\DBAL\Connection::connect to create connection before issuing a SAVEPOINT query to the database.
The same behavior is already implemented for Doctrine\DBAL\Connection::beginTransaction and Doctrine\DBAL\Connection::rollBack methods.
The same approach could be also applied to Doctrine\DBAL\Connection::releaseSavepoint and Doctrine\DBAL\Connection::rollbackSavepoint.

[Ocramius]

Would you be able to send in a test and a fix? Adding a $this->connect() call seems trivial, but we need a test case to prevent a regression.

[tezvi]

Sure, I'll give it a go.

What do you think should we also log SAVEPOINT related queries like here:

dbal/lib/Doctrine/DBAL/Connection.php

Lines 1249 to 1251 in 9b88bf3

	if ($logger) {
	$logger->startQuery('"SAVEPOINT"');
	}

[Ocramius]

That would make a lot of sense, yes

[tezvi]

@Ocramius it seems it has already been fixed thx to @morozov #3443

[morozov]

@tezvi yes. It was detected by PHPStan as calling a method on a potentially null value.

[tezvi]

Nice, case closed then 😁
The only thing that might be missing is proper SQL logging. It is provided by rollback and commit methods (hardcoded), but could be reused from platform instance createSavePoint and releaseSavepoints. What do you think?

Example:

dbal/lib/Doctrine/DBAL/Connection.php

Line 1350 in 29c7ba6

$logger->startQuery('"ROLLBACK TO SAVEPOINT"');

[morozov]

@tezvi not sure what this is about. Is something not logged when it's supposed to be? Please feel free to file a new issue.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.