Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Connection::lastInsertId() #3596

Closed
morozov opened this issue Jun 6, 2019 · 3 comments · Fixed by #4324
Closed

Rework Connection::lastInsertId() #3596

morozov opened this issue Jun 6, 2019 · 3 comments · Fixed by #4324
Labels
Connections Improvement Platforms

Comments

@morozov
Copy link
Member

morozov commented Jun 6, 2019

Instead of the optional parameter, there should be two separate methods: one which returns the last inserted record ID if supported by the driver, the other returns the current value of the given sequence if supported by the platform.
@morozov morozov added this to the 3.0.0 milestone Jun 6, 2019
@morozov morozov changed the title Rework Connection::lastInsertId() Rework Connection::lastInsertId() Jun 6, 2019
@morozov
Copy link
Member Author

morozov commented Jun 6, 2019

Linking another similar issue: #3368.

@morozov morozov linked a pull request Jun 29, 2021 that will close this issue
Throw exception from lastInsertId() if there is no identity value #4324
Merged
@morozov morozov removed this from the 4.0.0 milestone Jul 17, 2021
@morozov
Copy link
Member Author

morozov commented Jul 17, 2021

Superseded by #4687.

@morozov morozov closed this as completed Jul 17, 2021
@morozov morozov removed the BC Break label Jul 17, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Connections Improvement Platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw exception from lastInsertId() if there is no identity value BenMorel/dbal
1 participant
@morozov