Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behaviour from PR#3442 in ForeignKeyConstraint::getUnqualifiedForeignTableName #3737

Closed
Alarich opened this issue Nov 18, 2019 · 1 comment · Fixed by #3790
Closed

Comments

@Alarich
Copy link

Alarich commented Nov 18, 2019

Bug Report

Greetings, I recently updated to 2.10 and found that my migrations no longer functioned properly. The background on that is most likely irrelevant, but essentially I'm using dynamic schema names and use the postGenerateSchema event to ensure my foreign keys are not reverted.

Q A
BC Break yes
Version 2.10.0

Summary

Doctrine\DBAL\Schema\ForeignKeyConstraint::getUnqualifiedForeignTableName is returning incorrect unqualified table names due to a change made to it in #3442 (link to change) and causing \Doctrine\DBAL\Schema\Comparator::diffForeignKey to result in a false positive.

Current behaviour

Foreign table name - "schema.table_name"
Unqualified table name - ".table_name"

Expected behaviour

Foreign table name - "schema.table_name"
Unqualified table name - "table_name"

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants