Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysqli::$sqlstate is inaccessible on a failed/non-initialized connection since PHP 8 #3947

Closed
morozov opened this issue Apr 13, 2020 · 2 comments · Fixed by #4081
Closed

mysqli::$sqlstate is inaccessible on a failed/non-initialized connection since PHP 8 #3947

morozov opened this issue Apr 13, 2020 · 2 comments · Fixed by #4081
Assignees
@morozov
Labels
Blocker Bug Connecting Connections mysqli PHP
Milestone
3.0.0

Comments

@morozov
Copy link
Member

morozov commented Apr 13, 2020

Q A
BC Break no
Version 3.0.0-dev

Summary

  1. https://bugs.php.net/bug.php?id=79469
  2. https://travis-ci.org/github/doctrine/dbal/jobs/673655058:

    Doctrine\DBAL\Tests\Driver\Mysqli\MysqliConnectionTest::testRestoresErrorHandlerOnException
    Error: Property access is not allowed yet
@morozov morozov added this to the 3.0.0 milestone Apr 13, 2020
@morozov morozov mentioned this issue Jun 17, 2020
Merged
@morozov
Copy link
Member Author

morozov commented Jun 17, 2020

Closed via #4081.

@morozov morozov linked a pull request Jun 17, 2020 that will close this issue
Simplify Driver::connect() signature #4081
Merged
@morozov morozov self-assigned this Jun 17, 2020
@morozov morozov closed this as completed Jun 18, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@morozov morozov

Labels
Blocker Bug Connecting Connections mysqli PHP
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Simplify Driver::connect() signature morozov/dbal
1 participant
@morozov