Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConversionException formats non-string scalar values as strings #4318

Closed
morozov opened this issue Oct 3, 2020 · 2 comments · Fixed by #4320
Closed

ConversionException formats non-string scalar values as strings #4318

morozov opened this issue Oct 3, 2020 · 2 comments · Fixed by #4320
Assignees
@morozov
Labels
Bug Error Handling Type Conversion
Milestone
3.0.0

Comments

@morozov
Copy link
Member

morozov commented Oct 3, 2020 •
edited
Loading

The following types are converted incorrectly:

  1. Could not convert PHP value '123' of type 'integer' […]
  2. Could not convert PHP value '-123' of type 'integer' […]
  3. Could not convert PHP value '12.34' of type 'double' […]
  4. Could not convert PHP value '1' of type 'boolean' […]
  5. Could not convert PHP value '' of type 'boolean' […]

The issue was discovered and suppressed in #4319.
@morozov morozov added this to the 3.0.0 milestone Oct 3, 2020
@morozov morozov mentioned this issue Oct 3, 2020
Merged
@morozov morozov linked a pull request Oct 9, 2020 that will close this issue
Properly format scalar values in ConversionException #4320
Merged
@morozov
Copy link
Member Author

morozov commented Oct 9, 2020

Fixed by #4320.

@morozov morozov closed this as completed Oct 9, 2020
@morozov morozov self-assigned this Oct 9, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@morozov morozov

Labels
Bug Error Handling Type Conversion
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Properly format scalar values in ConversionException morozov/dbal
1 participant
@morozov