-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL parser does not recognize comments #4383
Comments
If that works for you, please consider submitting a PR with that code. |
I believe we could reuse the re2c grammar used by PDO and solve this problem once and for all. Using the hoaproject/Compiler syntax, it will look like following:
And produce the following result:
Given that the Hoa project is being abandoned and is not really necessary to be used here, if there is a re2php implementation, we can compile and reuse the original grammar in the DBAL (both in Otherwise, we can manually put together a regex-based parser that uses the regexes above (see #4397). |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Bug Report
Summary
Function
Doctrine\DBAL\Driver\OCI8\OCI8Statement::convertPositionalToNamedPlaceholders()
does not skip comments, only literals (single quote) and identificators (double quote).Current behaviour
Warning: oci_bind_by_name(): ORA-01036: illegal variable name/number
Fatal error: Uncaught Doctrine\DBAL\Driver\OCI8\OCI8Exception: ORA-01008: not all variables bound
How to reproduce
Expected behaviour
As variant of convertPositionalToNamedPlaceholders:
The text was updated successfully, but these errors were encountered: