Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection::getParams() is @internal now: how to access params? #5213

Closed
dmaicher opened this issue Jan 26, 2022 · 3 comments
Closed

Connection::getParams() is @internal now: how to access params? #5213

dmaicher opened this issue Jan 26, 2022 · 3 comments

Comments

@dmaicher
Copy link
Contributor

Feature Request

Q A
New Feature yes
RFC yes
BC Break no

Related to #3593

Summary

I'm currently trying to fix an issue where I need access to the connection params inside an event listener for postConnect.

Since Connection::getParams() was marked @internal I currently don't see any other way of accessing data added by the Driver into the connection params.

Would you consider reverting the @internal change?

Or maybe as a new feature would it be possible to get access to the params inside the dispatched postConnect event ConnectionEventArgs?

@morozov
Copy link
Member

morozov commented Jan 26, 2022

The connection parameters are an implementation detail which we don't want to be part of the public API. See the details in #3593. If there is a logic that depends on connection parameters, they should be explicitly provided to this logic similarly to how they are provided to the connection.

Would you consider reverting the @internal change?

No.

@dmaicher
Copy link
Contributor Author

For now I will try to work around this.

@morozov morozov closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants