Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SequenceGenerator crashes with non-numeric value encountered when using XML Driver #6682

Closed
alextech opened this issue Sep 3, 2017 · 0 comments
Closed

SequenceGenerator crashes with non-numeric value encountered when using XML Driver #6682

alextech opened this issue Sep 3, 2017 · 0 comments
Assignees
@lcobucci
Labels
Bug
Milestone
2.5.13

Comments

@alextech
Copy link
Contributor

alextech commented Sep 3, 2017 •
edited
Loading

Using XML Driver causes crash at https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Id/SequenceGenerator.php#L81 during addition operation, because parser casts sequence parameters as strings, not integers.

Edit: because optional default values were missing.
alextech added a commit to alextech/doctrine2 that referenced this issue Sep 3, 2017
@alextech
Fix doctrine#6682. Cast sequence parameters as integers in XML driver.
98a4fc8
alextech added a commit to alextech/doctrine2 that referenced this issue Sep 3, 2017
@alextech
Fix doctrine#6682. Cast sequence parameters as integers in XML driver.
148b35a
@alextech alextech mentioned this issue Sep 3, 2017
Merged
alextech added a commit to alextech/doctrine2 that referenced this issue Sep 5, 2017
@alextech
doctrine#6682 Enforce sequence xsd requirement. Supply default values…
79becf3 
… for allocationSize and initialValue optional parameters.
alextech added a commit to alextech/doctrine2 that referenced this issue Sep 5, 2017
@alextech
doctrine#6682 Enforce sequence xsd requirement. Supply default values…
bfcab4d 
… for allocationSize and initialValue optional parameters.
lcobucci pushed a commit that referenced this issue Nov 26, 2017
@alextech @lcobucci
Enforce sequence XSD requirement
bb31472 
Supply default values for allocationSize and initialValue optional parameters.

Related to: #6682
lcobucci pushed a commit to alextech/doctrine2 that referenced this issue Nov 26, 2017
@alextech @lcobucci
Enforce sequence XSD requirement
b3331b2 
Supply default values for allocationSize and initialValue optional parameters.

Related to: doctrine#6682
lcobucci added a commit that referenced this issue Nov 26, 2017
@lcobucci
Merge pull request #6683 from alextech/bugfix/xml_sequence_params
3ca65e2 
Supply default values for optional values in sequence mapping if omitted by driver.

Fixes: #6682
@lcobucci lcobucci self-assigned this Nov 26, 2017
@lcobucci lcobucci added the Bug label Nov 26, 2017
@lcobucci lcobucci added this to the 2.5.13 milestone Nov 26, 2017
maglnet pushed a commit to maglnet/doctrine2 that referenced this issue Oct 10, 2018
@alextech @maglnet
Enforce sequence XSD requirement
fa68787 
Supply default values for allocationSize and initialValue optional parameters.

Related to: doctrine#6682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcobucci lcobucci

Labels
Bug
Projects
None yet
Milestone
2.5.13
Development

No branches or pull requests
2 participants
@lcobucci @alextech