Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing in February (QueryDqlFunctionTest::testDateAdd with "month" dataset) #7031

Closed
Majkl578 opened this issue Feb 1, 2018 · 0 comments
Labels
Milestone

Comments

@Majkl578
Copy link
Contributor

Majkl578 commented Feb 1, 2018

https://travis-ci.org/doctrine/doctrine2/jobs/336054843#L616

1) Doctrine\Tests\ORM\Functional\QueryDqlFunctionTest::testDateAdd with data set "month" ('month', 1, 2592000, 172800) Failed asserting that 2378089 matches expected 2592000.

The "month" dataset for QueryDqlFunctionTest::testDateAdd works with assumption that month has 30 days +- delta 2 days, but in February the difference is larger (2378089s is ~27.52 days).
https://github.com/doctrine/doctrine2/blame/master/tests/Doctrine/Tests/ORM/Functional/QueryDqlFunctionTest.php#L351

Test added in #6742.
Applies to 2.6 & master.

/cc @lcobucci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant