Allow Symfony 4 #6733
Allow Symfony 4 #6733
Conversation
|
Besides not being able to actively work on OSS for a few weeks at the
moment, you know the drill: new things for new minor releases.
…On 28 Sep 2017 00:34, "Fabien Potencier" ***@***.***> wrote:
@nicolas-grekas <https://github.com/nicolas-grekas> added support for
Symfony 4.0, but only on the master branch, which is yet to be released. As
Symfony 4 will start to be in beta really soon now (next week), having
support for it in Doctrine 2.5 is critical.
I know that's a lot to ask, but is it possible to merge this PR and
release 2.5.12?
Thank you a lot for your help on this one.
------------------------------
You can view, comment on, or merge this pull request online at:
#6733
Commit Summary
- Allow Symfony 4
File Changes
- *M* composer.json
<https://github.com/doctrine/doctrine2/pull/6733/files#diff-0> (4)
Patch Links:
- https://github.com/doctrine/doctrine2/pull/6733.patch
- https://github.com/doctrine/doctrine2/pull/6733.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6733>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakKzKObQh6tnWgdXl658AWQpXunxfks5sms1fgaJpZM4PmfPe>
.
|
|
Is it really a new feature? Any ETA for the next Doctrine version? Not merging this pull request means no Doctrine for Symfony 4. Anybody else able to work with us on this issue before you have time? |
|
Note that the only change is about the console component, nothing core to Doctrine. |
|
I might be able to do the release on Sunday, since I'm commuting ~10h via 🚋. It must be clear that ORM 2.5 will not have this addition though, sorry. |
|
@fabpot When are you planning to release Symfony 4.0? |
|
I believe this weekend or very early next week. Feature freeze is technically Saturday. |
|
@jwage the scenario is quite simple, and it is the reason for never updating dependencies in patch releases:
I'm fine with bumping in a minor release, not in a patch release, since any environment must always be able to upgrade patch releases at any time due to possible security releases. |
That would most likely blow up in their face regardless of a patch or minor release: The current version constraint for TBH, I wouldn't consider that a problem: if you use something through an implicit dependency you shouldn't be surprised if that implicit dependency is no longer filled. Also, since we'd add |
|
@alcaeus I'm fine with changing this decision if there's enough consensus and this kind of crash is just removed from the BC compliance issues on our side: just need to make that very clear. Just to add to #6733 (comment), the removal of supported dependency versions should absolutely never happen (unrelated to this issue). The addition of a range is still a risk, IMO. |
|
I agree on the BC compliance issue, but then I'd always put blame on the user if an implicit dependency blows up in their face. |
I'm fine with this stance. If nobody has an issue with it, then we can backport to 2.5 too. |
|
👍 Sounds good. Thanks! |
Looks reasonable. Currently trying to install Doctrine or any package depending of Doctrine with Symfony 4 (already in beta) result in the following error: Not really a good user experience. |
|
+1 for backporting to 2.5 if possible, especially as I'm not sure when 2.6 would be landing. |
|
👍 Backporting to 2.5 would be great. Thanks! |
|
👍 for backporting to 2.5 |
|
Cool, I can confirm it works now with Symfony 4. There is still an issue with the integration bundle and Symfony 4, but it is just pending on a new release. Ticket here: doctrine/DoctrineBundle#720 |
@nicolas-grekas added support for Symfony 4.0, but only on the master branch, which is yet to be released. As Symfony 4 will start to be in beta really soon now (next week), having support for it in Doctrine 2.5 is critical.
I know that's a lot to ask, but is it possible to merge this PR and release 2.5.12?
Thank you a lot for your help on this one.