--all-or-nothing option is very confusing

[lazka]

Q	A
Version	3.1.5

I was running the following:

bin/console doctrine:migrations:migrate --em=my_em --no-interaction --all-or-nothing

Turns out just passing --all-or-nothing does not do anything, you have to pass --all-or-nothing=1 or --all-or-nothing=0 for it to have any effect:

migrations/lib/Doctrine/Migrations/Tools/Console/ConsoleInputMigratorConfigurationFactory.php

Line 24 in 5713b45

$allOrNothing = $input->hasOption('all-or-nothing') ? $input->getOption('all-or-nothing') : null;

(it will result in null, then fall back to the configuration)

This is very confusing imo and there are lots of examples out there that just pass --all-or-nothing.

Am I missing something?

[greg0ire]

What do the docs say?

[agustingomes]

I created a PR to correct the docs example: #1296 as I just found this issue while working on automating Doctrine migrations in my work context.

@greg0ire what do you think?

[greg0ire]

I'll try to look into it but have you seen #1161 ? Before it was merged, I think the --all-or-nothing must have been working as expected, because back then the code looked a lot like the code for the dry-run option (which works as expected, right?)

I think the code in that MR might be wrong. It should not fall back on the configuration as soon as $input->hasOption('all-or-nothing') returns true, right?

[greg0ire]

Cc @grachevko

[agustingomes]

Added a test case in the PR confirming the current (and unexpected) behavior.