Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dependency injection for console commands #726

Closed
jwage opened this issue Jun 5, 2018 · 3 comments
Closed

Use dependency injection for console commands #726

jwage opened this issue Jun 5, 2018 · 3 comments
Milestone

Comments

@jwage
Copy link
Member

jwage commented Jun 5, 2018

Right now we rely on service location and Symfony console helper sets in order to get the dependencies for commands. This makes testing a pain and the code is less than ideal. We need to clean this up and rely on dependency injection for the commands.

@jwage jwage added this to the 3.0 milestone Jun 5, 2018
@stof
Copy link
Member

stof commented Jun 6, 2018

while this is fine for the usage in the Symfony bundle (we can configure commands there), it might be harder for the standalone CLI.

@goetas
Copy link
Member

goetas commented Dec 1, 2019

Should have been solved in #858

@goetas
Copy link
Member

goetas commented Jan 14, 2020

done in #898

@goetas goetas closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants