Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object could not be converted to string after upgrade to 2.6.0 #7025

Closed
pepakriz opened this issue Jan 31, 2018 · 5 comments
Closed

Object could not be converted to string after upgrade to 2.6.0 #7025

pepakriz opened this issue Jan 31, 2018 · 5 comments

Comments

@pepakriz
Copy link
Contributor

Hi,

After upgrade to 2.6.0 I got Object could not be converted to string after upgrade to 2.6.0.

Mybe because this PR: #6141 . Now custom types must implement __toString method when they are used as discriminators. Is this behaviour correct?

@Ocramius
Copy link
Member

@pepakriz discriminators didn't support object values before 2.6

@pepakriz
Copy link
Contributor Author

pepakriz commented Feb 1, 2018

Maybe not officially, but it works on my code (version 2.5.14) without __toString :)

@Ocramius
Copy link
Member

Ocramius commented Feb 1, 2018

In a reproducible way? Can you compare your code to the one in #6141 and see if there are any major differences?

@stollr
Copy link
Contributor

stollr commented Oct 25, 2018

@Ocramius I think this issue can be closed, because there has not been any feedback.

@lcobucci
Copy link
Member

Closing here due to inactivity, we can reopen once we have a way to reproduce it.

@lcobucci lcobucci self-assigned this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants