fix: inferred properties duplicating explicitly specified ones

documentationjs · Dec 21, 2018 · 2d0bd0e · 2d0bd0e
1 parent 44e36c9
commit 2d0bd0e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/__tests__/lib/infer/properties.js b/__tests__/lib/infer/properties.js
@@ -29,6 +29,20 @@ test('inferProperties', function() {
  }
  ]);
 
+ expect(
+ evaluate('/** @property {number} b */ type a = { b: 1 };').properties
+ ).toEqual([
+ {
+ lineNumber: 0,
+ name: 'b',
+ title: 'property',
+ type: {
+ name: 'number',
+ type: 'NameExpression'
+ }
+ }
+ ]);
+
  expect(
  evaluate('/** */interface a { b: 1, c: { d: 2 } };').properties
  ).toEqual([

diff --git a/src/infer/properties.js b/src/infer/properties.js
@@ -35,7 +35,7 @@ function inferProperties(comment) {
  const explicitProperties = new Set();
  // Ensure that explicitly specified properties are not overridden
  // by inferred properties
- comment.properties.forEach(prop => explicitProperties.add(prop));
+ comment.properties.forEach(prop => explicitProperties.add(prop.name));
 
  function inferProperties(value, prefix) {
  if (value.type === 'ObjectTypeAnnotation') {