Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for class param declarations at the constructor #1013

Merged
merged 1 commit into from
Feb 10, 2018

Conversation

shannon
Copy link
Contributor

@shannon shannon commented Feb 9, 2018

My main motivation for this was that VSCode intellisense does not work when constructor params are defined at the class declaration, it expects them at the constructor.

So I just merged the params from a constructor comment during the infer phase.

Relevant issue: #689

This was my first look into this code and I couldn't get the build to work locally let alone the tests so I'm hoping the tests can be checked in circle.

Edit: Just to clarify, I did actually test that it did what I wanted to by editing my local node_module/documentation/lib files directly. I was getting flow type syntax errors on build and I'm not very familiar with flow so this was the easiest way for me to work with it.

@coveralls
Copy link

coveralls commented Feb 9, 2018

Coverage Status

Coverage decreased (-0.04%) to 86.068% when pulling 64185e8 on shannon:master into 647fdf4 on documentationjs:master.

Copy link
Member

@tmcw tmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tmcw tmcw merged commit 05c5279 into documentationjs:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants