Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for empty diff #1273

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Fix check for empty diff #1273

merged 2 commits into from
Sep 9, 2019

Conversation

voxpelli
Copy link
Contributor

Compare to the result of the latest diff module: https://runkit.com/embed/y4qzdzzz05qr

No diff currently gives this result:

Index: 
===================================================================
--- 	
+++ 	

But the current check expect it to result in an empty string, causing the --diff-only flag in the readme CLI to fail.

Compare to the result of the latest diff module: https://runkit.com/embed/y4qzdzzz05qr

No diff gives this result:

```
Index: 
===================================================================
--- 	
+++ 	
```
@tmcw tmcw merged commit 3e0958b into documentationjs:master Sep 9, 2019
@voxpelli voxpelli deleted the voxpelli-patch-1 branch September 10, 2019 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants