Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: groups in toc #895

Merged
merged 1 commit into from
Sep 4, 2017
Merged

Conversation

rhendric
Copy link
Contributor

@rhendric rhendric commented Sep 2, 2017

Fixes #582

See docs/CONFIG.md for usage, but this is pretty much just as straightforward an implementation of #582 as I could manage.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 77.959% when pulling c2ab10d on rhendric:feat/toc-groups into b486988 on documentationjs:master.

@rhendric
Copy link
Contributor Author

rhendric commented Sep 2, 2017

For the record, something—I don't know what—is wrong with the coverage report. If I remove one of the lines that this report claims aren't being hit, my new test fails. Is it possible I wrote the test incorrectly such that its contribution to coverage isn't being collected?

@tmcw
Copy link
Member

tmcw commented Sep 4, 2017

Coveralls just fails whenever coverage decreases, it's too picky in that sense. I'll reconfigure it so that it doesn't flag all the PRs in this repo.

@tmcw tmcw merged commit c94412a into documentationjs:master Sep 4, 2017
@rhendric rhendric deleted the feat/toc-groups branch September 4, 2017 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants