Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series activities json should be sorted correctly #4296

Closed
jorg-vr opened this issue Jan 3, 2023 · 0 comments · Fixed by #4302
Closed

Series activities json should be sorted correctly #4296

jorg-vr opened this issue Jan 3, 2023 · 0 comments · Fixed by #4302
Labels
bug Something isn't working medium priority Things we want to see implemented relatively soon

Comments

@jorg-vr
Copy link
Contributor

jorg-vr commented Jan 3, 2023

Currently these activities are sorted by popularity. Expected behaviour would be for these activities to be sorted by series order.

This results in incorrect sorting in plugins

eg: https://dodona.ugent.be/nl/series/2518/activities.json

Potential cause: #4222

Potential solution:

Apply default sort only when no series is present (Line 71)
Instead of here: https://github.com/dodona-edu/dodona/pull/4222/files#diff-6c3192e53b5a2e74e2fe29782dce058fe0398676d09068812b92c40d88625755R80

@jorg-vr jorg-vr added bug Something isn't working medium priority Things we want to see implemented relatively soon labels Jan 3, 2023
@bmesuere bmesuere added this to Roadmap Jan 3, 2023
@github-project-automation github-project-automation bot moved this to Unplanned in Roadmap Jan 3, 2023
@github-project-automation github-project-automation bot moved this from Unplanned to Done in Roadmap Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium priority Things we want to see implemented relatively soon
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant