Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side processing of annotations sometimes eats code #4920

Closed
chvp opened this issue Aug 28, 2023 · 3 comments · Fixed by #4921
Closed

Client-side processing of annotations sometimes eats code #4920

chvp opened this issue Aug 28, 2023 · 3 comments · Fixed by #4921
Labels
bug Something isn't working

Comments

@chvp
Copy link
Member

chvp commented Aug 28, 2023

See e.g. https://dodona.be/nl/submissions/14682928/. On line 19 there is an else. This can also be seen in the raw HTML returned from the server. This else is however not visible in the code view and also can't be found with "Inspect element".

@chvp chvp added the bug Something isn't working label Aug 28, 2023
@github-project-automation github-project-automation bot moved this to Unplanned in Roadmap Aug 28, 2023
@chvp
Copy link
Member Author

chvp commented Aug 28, 2023

Did some more investigating. An error happens when an annotation's starting column is past the end of the line (which happens with a missing :, because it is expected after the else).

@pdawyndt
Copy link
Contributor

pdawyndt commented Sep 8, 2023

Current fix seems to have an unwanted side effect. Missing semicolons that used to be indicates with an anchor after the last character on the line are now indicates by underlining the entire line. This conflicts with how it was intended by the linter and how the linting messages are displayed in most editors, and it gives much more clutter in displaying code with lots of missing semicolons.

image

Example: submission

@pdawyndt pdawyndt reopened this Sep 8, 2023
@github-project-automation github-project-automation bot moved this from Done to Todo in Roadmap Sep 8, 2023
@chvp
Copy link
Member Author

chvp commented Sep 8, 2023

This was done by design (see the first line of the description of the fixing PR). There's no concept of "past the end of the line" in our code view, so I opted to let it signify "there's a problem on this line".

@chvp chvp closed this as completed Sep 8, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants