Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whole ListItem clickable #18

Closed
jlnrrg opened this issue Apr 20, 2021 · 2 comments
Closed

Whole ListItem clickable #18

jlnrrg opened this issue Apr 20, 2021 · 2 comments
Labels
wontfix This will not be worked on

Comments

@jlnrrg
Copy link
Contributor

jlnrrg commented Apr 20, 2021

overview page -> extend <a></a> over the whole ListItem and not just the title,
so the whole item is clickable

(I used the web version on a desktop pc, might be implemented already on mobile, I'm not sure)

@doersino
Copy link
Owner

At least in search results, I've already implemented this a while ago.

As I've written in #1:

Inside the main portion of the index page, the user could have added their own links as part of recipe descriptions. Wrapping the link to the recipe around the whole list item would render such links inoperable.

@doersino doersino added the wontfix This will not be worked on label Apr 20, 2021
@jlnrrg
Copy link
Contributor Author

jlnrrg commented Apr 20, 2021

@doersino sorry I overlooked this.
I think what you describe is a relative small use case, as one can always link a source in the source tag.
But I can understand the hesitation because it would introduce a limit here.
Would it be possible to check if the text includes a link and then act respectively?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants